Skip to content

doc: updated outbound traffic information for operator hub access #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2024
Merged

doc: updated outbound traffic information for operator hub access #506

merged 5 commits into from
Sep 11, 2024

Conversation

@imprateeksh
Copy link
Member

Description

Issue: 10133

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh imprateeksh self-assigned this Sep 2, 2024
@imprateeksh imprateeksh marked this pull request as ready for review September 2, 2024 10:51
@imprateeksh
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imprateeksh Thinking about this more, perhaps we do set disable_outbound_traffic_protection to true in the basic example (add a code comment to explaining what it does, or pointing to relevant IKS docs) and update the title of this example to Basic single zone cluster with allowed outbound traffic

@imprateeksh
Copy link
Member Author

imprateeksh commented Sep 5, 2024 •
edited
Loading

@imprateeksh Thinking about this more, perhaps we do set disable_outbound_traffic_protection to true in the basic example (add a code comment to explaining what it does, or pointing to relevant IKS docs) and update the title of this example to Basic single zone cluster with allowed outbound traffic

Hi @ocofaigh - In basic example, currently we are not setting disable_outbound_traffic_protection as true and it picks up the default value which is false. This can be seen here and unlike other versions, the value is taken from variable's default value.

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

Basic example test is also successful. Logs from basic example (using OCP version 4.15) are shared here:
output_test_basic_example.log

@ocofaigh ocofaigh merged commit 9fad4d8 into main Sep 11, 2024
@ocofaigh ocofaigh deleted the 484-op-hub branch September 11, 2024 12:29
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.30.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

Assignees

@imprateeksh imprateeksh

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imprateeksh @terraform-ibm-modules-ops @ocofaigh